Add filtering by code to vouchers in UI, fix e2e by witoszekdev · Pull Request #6409 · saleor/saleor-dashboard

witoszekdev · 2026-03-10T16:21:40Z

Added option to filter gift cards by code in "Filter" menu, updated e2e test to use that filtering instead of search which takes a moment to index, which sometimes failed in test environment.

indexing, not available immediately)

changeset-bot · 2026-03-10T16:21:47Z

🦋 Changeset detected

Latest commit: f99a45e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

codecov · 2026-03-10T16:40:08Z

Codecov Report

❌ Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.19%. Comparing base (659142b) to head (f99a45e).

Files with missing lines	Patch %	Lines
...initialState/giftCards/useInitialGiftCardsState.ts	0.00%	3 Missing ⚠️
...ents/ConditionalFilter/API/initialState/helpers.ts	0.00%	2 Missing ⚠️
...ilter/API/providers/GiftCardsFilterAPIProvider.tsx	0.00%	1 Missing and 1 partial ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #6409      +/-   ##
==========================================
- Coverage   43.19%   43.19%   -0.01%     
==========================================
  Files        2527     2527              
  Lines       44074    44081       +7     
  Branches    10440    10405      -35     
==========================================
+ Hits        19037    19040       +3     
- Misses      23715    23718       +3     
- Partials     1322     1323       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

Adds a “Code” filter to the Gift Cards conditional filter UI and updates the Playwright E2E test to use that filter instead of search (to avoid eventual indexing delays).

Changes:

Add Gift Cards “Code” filter operand + condition configuration.
Extend URL token parsing / initial-state plumbing to carry code through the conditional filter system.
Update Gift Cards E2E to apply a “Code” text filter via the filters UI.

Reviewed changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
src/components/ConditionalFilter/constants.ts	Adds the Gift Cards “Code” left operand and a new static condition entry.
src/components/ConditionalFilter/ValueProvider/UrlToken.ts	Marks `code` as a loadable static token for gift cards.
src/components/ConditionalFilter/ValueProvider/TokenArray/fetchingParams.ts	Adds `code` to gift-card fetching params + empty defaults.
src/components/ConditionalFilter/ValueProvider/TokenArray/fetchingParams.test.ts	Updates expectations to include `code` in params.
src/components/ConditionalFilter/API/providers/GiftCardsFilterAPIProvider.tsx	Adds a handler branch intended for the new code filter.
src/components/ConditionalFilter/API/initialState/helpers.ts	Threads `code` into initial gift-card state creation.
src/components/ConditionalFilter/API/initialState/giftCards/useInitialGiftCardsState.ts	Passes `code` into initial state and response.
src/components/ConditionalFilter/API/initialState/giftCards/InitialGiftCardsState.ts	Adds `code` storage/lookup for URL token rehydration.
playwright/tests/giftCards.spec.ts	Switches E2E from search to “Code” filter flow.
playwright/pages/pageElements/filtersPage.ts	Adds helper to pick a text filter in the filters UI.
playwright/pages/giftCardsPage.ts	Wires `FiltersPage` into the GiftCards page object.

Copilot · 2026-03-11T12:26:23Z

src/components/ConditionalFilter/constants.ts

  isPreorder: [{ type: "select", label: "is", value: "input-1" }],
  isGiftCardUsed: [{ type: "select", label: "is", value: "input-1" }],
  isGiftCardBought: [{ type: "select", label: "is", value: "input-1" }],
+  giftCardCode: [{ type: "text", label: "is", value: "input-1" }],


STATIC_CONDITIONS key is giftCardCode, but the gift card left operand uses slug: "code"/value: "code". URL tokens and FilterElement.rowType() use value.value (the slug), so this mismatch prevents the condition from being rehydrated from URL and can make the filter behave as "unknown". Align the static condition key with the URL/slug (e.g. use code as the STATIC_CONDITIONS key) so ConditionOptions.isStaticName(token.name) works for this filter.

Suggested change

giftCardCode: [{ type: "text", label: "is", value: "input-1" }],

code: [{ type: "text", label: "is", value: "input-1" }],

src/components/ConditionalFilter/constants.ts

src/components/ConditionalFilter/API/providers/GiftCardsFilterAPIProvider.tsx

Copilot · 2026-03-11T12:26:24Z

src/components/ConditionalFilter/API/initialState/giftCards/InitialGiftCardsState.ts

      case "usedBy":
        return this.usedBy;
+      case "code":
+        return this.code;
      default:


InitialGiftCardsStateResponse now supports resolving code tokens via getEntryByName, but the existing unit tests for filterByUrlToken() don’t cover this new case (they cover currency/tags/products/usedBy/isActive). Add a test for the code field to ensure URL rehydration works and to catch regressions when adjusting the code/giftCardCode naming.

Copilot

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 3 comments.

Copilot · 2026-03-11T14:12:34Z

.changeset/eager-snails-do.md

+"saleor-dashboard": patch
+---
+
+Gift cards filters now have option to filder by gift card code explicitly. Previously this was available only in search box, which uses `search` query, this however might not be available immediately after creating a gift card, due to indexing running in the background.


Typo in changeset text: "filder" should be "filter".

Suggested change

Gift cards filters now have option to filder by gift card code explicitly. Previously this was available only in search box, which uses `search` query, this however might not be available immediately after creating a gift card, due to indexing running in the background.

Gift cards filters now have option to filter by gift card code explicitly. Previously this was available only in search box, which uses `search` query, this however might not be available immediately after creating a gift card, due to indexing running in the background.

Copilot · 2026-03-11T14:12:35Z

src/components/ConditionalFilter/constants.ts

+    value: "code",
+    label: "Code",
+    type: "code",
+    slug: "code",
+    maxOccurrences: 1,
+  },


New "Code" gift card filter is added, but there’s no unit test asserting how it maps into createGiftCardQueryVariables output (e.g. that a text "is" condition produces GiftCardFilterInput.code). Adding a focused test case in src/components/ConditionalFilter/queryVariables.test.ts would prevent regressions in this new filtering capability.

Copilot · 2026-03-11T14:12:35Z

playwright/pages/giftCardsPage.ts


  readonly setGiftCardsBalanceDialog: SetGiftCardsBalanceDialog;

+  readonly filtersPage!: FiltersPage;


filtersPage is always initialized in the constructor, so the definite assignment assertion (!) is unnecessary and can mask real initialization issues. Declare it as readonly filtersPage: FiltersPage; instead.

Suggested change

readonly filtersPage!: FiltersPage;

readonly filtersPage: FiltersPage;

witoszekdev added 2 commits March 10, 2026 17:20

add filtering by code to giftcards in ui

d9c64f1

fix: e2e use filtering for gift card code, instead of search (uses

a0e68ca

indexing, not available immediately)

witoszekdev requested a review from a team as a code owner March 10, 2026 16:21

witoszekdev requested review from Copilot and lkostrowski and removed request for Copilot March 10, 2026 16:21

witoszekdev added test deployment Deploy Pull Request to *.saleor.rocks environment run pw-e2e Run e2e (basic suite from PR automation) labels Mar 10, 2026

github-actions bot temporarily deployed to pr-6409 March 10, 2026 16:30 Destroyed

witoszekdev marked this pull request as draft March 10, 2026 16:41

Merge branch 'main' into fix-vouchers-search-e2e

0225d79

Copilot AI review requested due to automatic review settings March 11, 2026 12:19

Copilot started reviewing on behalf of witoszekdev March 11, 2026 12:20 View session

witoszekdev added run pw-e2e Run e2e (basic suite from PR automation) test deployment Deploy Pull Request to *.saleor.rocks environment and removed run pw-e2e Run e2e (basic suite from PR automation) test deployment Deploy Pull Request to *.saleor.rocks environment labels Mar 11, 2026

add changeset

dc66282

witoszekdev added test deployment Deploy Pull Request to *.saleor.rocks environment run pw-e2e Run e2e (basic suite from PR automation) and removed run pw-e2e Run e2e (basic suite from PR automation) test deployment Deploy Pull Request to *.saleor.rocks environment labels Mar 11, 2026

Copilot AI reviewed Mar 11, 2026

View reviewed changes

github-actions bot temporarily deployed to pr-6409 March 11, 2026 12:26 Destroyed

fix filtering by code

8f5c3d8

witoszekdev added run pw-e2e Run e2e (basic suite from PR automation) and removed run pw-e2e Run e2e (basic suite from PR automation) test deployment Deploy Pull Request to *.saleor.rocks environment labels Mar 11, 2026

Merge branch 'main' into fix-vouchers-search-e2e

97da61d

Copilot AI review requested due to automatic review settings March 11, 2026 14:01

witoszekdev marked this pull request as ready for review March 11, 2026 14:02

Copilot started reviewing on behalf of witoszekdev March 11, 2026 14:03 View session

github-actions bot temporarily deployed to pr-6409 March 11, 2026 14:05 Destroyed

Merge branch 'main' into fix-vouchers-search-e2e

7f1fd35

witoszekdev added run pw-e2e Run e2e (basic suite from PR automation) and removed run pw-e2e Run e2e (basic suite from PR automation) labels Mar 11, 2026

github-actions bot temporarily deployed to pr-6409 March 11, 2026 14:10 Destroyed

Copilot AI reviewed Mar 11, 2026

View reviewed changes

witoszekdev added 2 commits March 11, 2026 17:04

update giftcard assertion

e2cd87a

update app id after snapshot change

f99a45e

witoszekdev added run pw-e2e Run e2e (basic suite from PR automation) and removed run pw-e2e Run e2e (basic suite from PR automation) labels Mar 11, 2026

github-actions bot deployed to pr-6409 March 11, 2026 16:31 View deployment

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add filtering by code to vouchers in UI, fix e2e#6409

Add filtering by code to vouchers in UI, fix e2e#6409
witoszekdev wants to merge 9 commits intomainfrom
fix-vouchers-search-e2e

witoszekdev commented Mar 10, 2026 •

edited

Loading

Uh oh!

changeset-bot bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

codecov bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Copilot AI Mar 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	giftCardCode: [{ type: "text", label: "is", value: "input-1" }],
	code: [{ type: "text", label: "is", value: "input-1" }],

	Gift cards filters now have option to filder by gift card code explicitly. Previously this was available only in search box, which uses `search` query, this however might not be available immediately after creating a gift card, due to indexing running in the background.
	Gift cards filters now have option to filter by gift card code explicitly. Previously this was available only in search box, which uses `search` query, this however might not be available immediately after creating a gift card, due to indexing running in the background.


		readonly setGiftCardsBalanceDialog: SetGiftCardsBalanceDialog;

		readonly filtersPage!: FiltersPage;

	readonly filtersPage!: FiltersPage;
	readonly filtersPage: FiltersPage;

Conversation

witoszekdev commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

changeset-bot bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

codecov bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Mar 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

witoszekdev commented Mar 10, 2026 •

edited

Loading

changeset-bot bot commented Mar 10, 2026 •

edited

Loading

codecov bot commented Mar 10, 2026 •

edited

Loading